Skip to content

Hacktoberfest 2020: Conway's Game of Life #3070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Nov 29, 2020
Merged

Hacktoberfest 2020: Conway's Game of Life #3070

merged 17 commits into from
Nov 29, 2020

Conversation

melody-notpond
Copy link
Contributor

@melody-notpond melody-notpond commented Oct 8, 2020

Describe your change:

Added Conway's Game of Life.

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

@melody-notpond melody-notpond changed the title Conway's Game of Life Hacktoberfest 2020: Conway's Game of Life Oct 16, 2020
@poyea poyea self-assigned this Oct 23, 2020
@poyea poyea added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 23, 2020
@poyea
Copy link
Member

poyea commented Oct 23, 2020

I see another Game of Life in this repo. Do you think we can move these 2 (yours and that one) into one folder? https://github.com/TheAlgorithms/Python/blob/master/other/game_of_life.py

@melody-notpond
Copy link
Contributor Author

Ohp I didn't realise that existed! Yeah we should probably move them both into the cellular_automata folder right?

@cclauss
Copy link
Member

cclauss commented Oct 30, 2020

from typing import List

Fixes...

cellular_automata/conways_game_of_life.py:26:27: F821 undefined name 'List'
cellular_automata/conways_game_of_life.py:26:32: F821 undefined name 'List'
cellular_automata/conways_game_of_life.py:26:47: F821 undefined name 'List'
cellular_automata/conways_game_of_life.py:26:52: F821 undefined name 'List'

@stale
Copy link

stale bot commented Nov 29, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Used to mark an issue or pull request stale. label Nov 29, 2020
@stale stale bot removed the stale Used to mark an issue or pull request stale. label Nov 29, 2020
@ghost ghost added awaiting reviews This PR is ready to be reviewed require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html and removed awaiting reviews This PR is ready to be reviewed labels Nov 29, 2020
@ghost ghost added the tests are failing Do not merge until tests pass label Nov 29, 2020
@ghost ghost removed the tests are failing Do not merge until tests pass label Nov 29, 2020
@cclauss cclauss merged commit 5de90aa into TheAlgorithms:master Nov 29, 2020
stokhos pushed a commit to stokhos/Python that referenced this pull request Jan 3, 2021
* Created conways_game_of_life.py

* Added new_generation(list[int[int]]) -> list[list[int]]

* Added glider example

* Added comments and shortened glider example

* Fixed index out of bounds error

* Added test

* Added blinker example

* Added ability to generate images

* Moved image generating code into a separate function

* Added comments

* Comment

* Reformatted file

* Formatting

* Removed glider test

* Update cellular_automata/conways_game_of_life.py

Co-authored-by: John Law <[email protected]>

* Update conways_game_of_life.py

* Update conways_game_of_life.py

Co-authored-by: John Law <[email protected]>
peRFectBeliever pushed a commit to peRFectBeliever/Python that referenced this pull request Apr 1, 2021
* Created conways_game_of_life.py

* Added new_generation(list[int[int]]) -> list[list[int]]

* Added glider example

* Added comments and shortened glider example

* Fixed index out of bounds error

* Added test

* Added blinker example

* Added ability to generate images

* Moved image generating code into a separate function

* Added comments

* Comment

* Reformatted file

* Formatting

* Removed glider test

* Update cellular_automata/conways_game_of_life.py

Co-authored-by: John Law <[email protected]>

* Update conways_game_of_life.py

* Update conways_game_of_life.py

Co-authored-by: John Law <[email protected]>
Panquesito7 pushed a commit to Panquesito7/Python that referenced this pull request May 13, 2021
* Created conways_game_of_life.py

* Added new_generation(list[int[int]]) -> list[list[int]]

* Added glider example

* Added comments and shortened glider example

* Fixed index out of bounds error

* Added test

* Added blinker example

* Added ability to generate images

* Moved image generating code into a separate function

* Added comments

* Comment

* Reformatted file

* Formatting

* Removed glider test

* Update cellular_automata/conways_game_of_life.py

Co-authored-by: John Law <[email protected]>

* Update conways_game_of_life.py

* Update conways_game_of_life.py

Co-authored-by: John Law <[email protected]>
shermanhui pushed a commit to shermanhui/Python that referenced this pull request Oct 22, 2021
* Created conways_game_of_life.py

* Added new_generation(list[int[int]]) -> list[list[int]]

* Added glider example

* Added comments and shortened glider example

* Fixed index out of bounds error

* Added test

* Added blinker example

* Added ability to generate images

* Moved image generating code into a separate function

* Added comments

* Comment

* Reformatted file

* Formatting

* Removed glider test

* Update cellular_automata/conways_game_of_life.py

Co-authored-by: John Law <[email protected]>

* Update conways_game_of_life.py

* Update conways_game_of_life.py

Co-authored-by: John Law <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted to be counted towards Hacktoberfest require tests Tests [doctest/unittest/pytest] are required require type hints https://docs.python.org/3/library/typing.html
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants